Skip to content

Add test for transient-local delivery with unbounded uint8 messages#3195

Merged
ahcorde merged 1 commit into
rollingfrom
nvcyc/transient_local_pub
Jul 17, 2026
Merged

Add test for transient-local delivery with unbounded uint8 messages#3195
ahcorde merged 1 commit into
rollingfrom
nvcyc/transient_local_pub

Conversation

@nvcyc

@nvcyc nvcyc commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Description

Add regression coverage for transient-local delivery of messages containing an unbounded uint8[].

The new test extends the existing wait_for_message test executable using test_msgs::msg::UnboundedSequences. It publishes a message before creating the subscription and verifies that the late-joining transient-local subscription receives the retained sample.

This test is specific for testing the case raised by ros2/rmw_fastrtps#897

Is this user-facing behavior change?

No.

Did you use Generative AI?

Yes. OpenAI GPT-5.6 was used to draft the code for this PR.

@nvcyc nvcyc mentioned this pull request Jul 14, 2026
Merged
@mergify

mergify Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@nvcyc nvcyc mentioned this pull request Jul 14, 2026
Closed
@nvcyc

nvcyc commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Pulls: ros2/rmw_fastrtps#898, #3195
Gist: https://gist.githubusercontent.com/nvcyc/296dc9c63b24f2ce985848357a15d483/raw/86de467d57f0c40e48e57b1ab0bad99647d4cbe1/ros2.repos
BUILD args: --continue-on-error --packages-above-and-dependencies rmw_fastrtps_cpp rclcpp
TEST args: --packages-above rmw_fastrtps_cpp rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19849

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@nvcyc nvcyc mentioned this pull request Jul 15, 2026
Merged
hidmic
hidmic reviewed Jul 15, 2026
View reviewed changes

@hidmic hidmic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test LGTM

@nvcyc

nvcyc commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

Pulls: ros2/rmw_fastrtps#898, #3195, ros2/rmw_zenoh#1009
Gist: https://gist.githubusercontent.com/nvcyc/0f64553f7078a24f8fff4febe2d81865/raw/f570b4632a54b47775084efad2918168dc8cc0f7/ros2.repos
BUILD args: --continue-on-error --packages-above-and-dependencies rmw_fastrtps_cpp rclcpp rmw_zenoh_cpp
TEST args: --packages-above rmw_fastrtps_cpp rclcpp rmw_zenoh_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19884

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde

ahcorde commented Jul 17, 2026

Copy link
Copy Markdown
Contributor
  • Linux-rhel Build Status

@ahcorde
ahcorde merged commit 859b29c into rolling Jul 17, 2026
3 checks passed
@ahcorde
ahcorde deleted the nvcyc/transient_local_pub branch July 17, 2026 12:56
@mergify mergify Bot mentioned this pull request Jul 17, 2026
Open
@nvcyc

nvcyc commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

https://github.com/Mergifyio backport lyrical

@mergify

mergify Bot commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

backport lyrical

✅ Backports have been created

Details

@mergify mergify Bot mentioned this pull request Jul 17, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hidmic hidmic hidmic left review comments
@ahcorde ahcorde ahcorde approved these changes
@fujitatomoya fujitatomoya fujitatomoya approved these changes
@mjcarroll mjcarroll Awaiting requested review from mjcarroll
@karsten-nvidia karsten-nvidia Awaiting requested review from karsten-nvidia
@yuanknv yuanknv Awaiting requested review from yuanknv
+1 more reviewer
@MiguelCompany MiguelCompany MiguelCompany approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nvcyc @ahcorde @hidmic @MiguelCompany @fujitatomoya